Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new RBAC configuration for k8sgpt #434

Merged
merged 5 commits into from
Jun 6, 2024

Conversation

MateSousa
Copy link
Contributor

Closes #259

πŸ“‘ Description

Migrate all RBAC related resources to Helm chart's templates

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

Signed-off-by: Matheus Sousa <matessousa@outlook.com>
Signed-off-by: Matheus Sousa <matessousa@outlook.com>
@MateSousa MateSousa requested review from a team as code owners May 2, 2024 02:04
Signed-off-by: Matheus Sousa    <73663610+MateSousa@users.noreply.github.com>
@MateSousa
Copy link
Contributor Author

@arbreezy sorry for the mess, now it's ok, and sorry for the delay, where I live we had a flu attack that made me sick.

Copy link
Contributor

@JuHyung-Son JuHyung-Son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@arbreezy
Copy link
Member

arbreezy commented Jun 3, 2024

thanks @MateSousa
I just need to find time to test it with existing k8sgpt-operator installations so we make sure it doesn't break anything

@AlexsJones
Copy link
Member

thanks @MateSousa I just need to find time to test it with existing k8sgpt-operator installations so we make sure it doesn't break anything

Let me know if you get a chance or I will later this week

@arbreezy
Copy link
Member

arbreezy commented Jun 5, 2024

DCO is not happy cause commits in this PR have been signed off with different email addresses.

A quick workaround is to re-open the PR and re-sign your commit(s) @MateSousa
I'm not sure if just resigning the commits, will trigger a new DCO check
cc: @AlexsJones

@AlexsJones AlexsJones merged commit 2d5954c into k8sgpt-ai:main Jun 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Migrate all RBAC related resources to Helm chart's templates
4 participants