feat: fix grpc client creation slightly #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
controllers/k8sgpt_controller.go
Outdated
| if os.Getenv("LOCAL_MODE") != "" { | ||
| address = "localhost:8080" | ||
| } else { | ||
| address = os.Getenv("K8SGPT_API_HOST") |
There was a problem hiding this comment.
What happens if this variable is not set?
There was a problem hiding this comment.
What should the new slug be:
address = fmt.Sprintf("http://%s.%s:8080/analyze", deployment.Name, deployment.Namespace)
?
There was a problem hiding this comment.
Yes, or something like this :
address = fmt.Sprintf("http://%s.%s:8080/analyze", "k8sgpt", deployment.Namespace)
What do you think ?
There was a problem hiding this comment.
Is that the right API for the grpc impl? I thought usually it would be v1/analyze etc?
There was a problem hiding this comment.
No good spot ! Let me check
There was a problem hiding this comment.
We only need something like this : address = fmt.Sprintf("%s.%s:8080", "k8sgpt", deployment.Namespace)
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
📑 Description
✅ Checks
ℹ Additional Information