From 947e94f35379712a2fb1e2a2c90636606e0e44b6 Mon Sep 17 00:00:00 2001 From: Patrick Pichler Date: Tue, 25 Apr 2023 13:08:42 +0200 Subject: [PATCH] fix: use correct result slice for cronjob analyzer Signed-off-by: Patrick Pichler --- pkg/analyzer/cronjob.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/pkg/analyzer/cronjob.go b/pkg/analyzer/cronjob.go index 31fb4e800d..b9ab541cee 100644 --- a/pkg/analyzer/cronjob.go +++ b/pkg/analyzer/cronjob.go @@ -33,11 +33,9 @@ func (analyzer CronJobAnalyzer) Analyze(a common.Analyzer) ([]common.Result, err "analyzer_name": kind, }) - var results []common.Result - cronJobList, err := a.Client.GetClient().BatchV1().CronJobs(a.Namespace).List(a.Context, v1.ListOptions{}) if err != nil { - return results, err + return nil, err } var preAnalysis = map[string]common.PreAnalysis{} @@ -114,7 +112,7 @@ func (analyzer CronJobAnalyzer) Analyze(a common.Analyzer) ([]common.Result, err Name: key, Error: value.FailureDetails, } - a.Results = append(results, currentAnalysis) + a.Results = append(a.Results, currentAnalysis) } }