From 975813d3284719c877630ad20f90c6fe163283da Mon Sep 17 00:00:00 2001 From: Matthis Holleville Date: Fri, 31 Mar 2023 13:57:03 +0200 Subject: [PATCH] feat: check if filters does not empty on add & remove Signed-off-by: Matthis Holleville --- cmd/filters/add.go | 4 ++++ cmd/filters/remove.go | 8 ++++++++ 2 files changed, 12 insertions(+) diff --git a/cmd/filters/add.go b/cmd/filters/add.go index 5a280aa80d..b59379cb22 100644 --- a/cmd/filters/add.go +++ b/cmd/filters/add.go @@ -22,6 +22,10 @@ var addCmd = &cobra.Command{ // Verify filter exist invalidFilters := []string{} for _, f := range filters { + if f == "" { + color.Red("Filter cannot be empty. Please use correct syntax.") + os.Exit(1) + } foundFilter := false for _, filter := range analyzer.ListFilters() { if filter == f { diff --git a/cmd/filters/remove.go b/cmd/filters/remove.go index 3461a0d069..8ebdc48ef2 100644 --- a/cmd/filters/remove.go +++ b/cmd/filters/remove.go @@ -24,6 +24,14 @@ var removeCmd = &cobra.Command{ defaultFilters = []string{} } + // Check if input filters is not empty + for _, f := range filters { + if f == "" { + color.Red("Filter cannot be empty. Please use correct syntax.") + os.Exit(1) + } + } + // verify dupplicate filters example: k8sgpt filters remove Pod Pod uniqueFilters, dupplicatedFilters := util.RemoveDuplicates(filters) if len(dupplicatedFilters) != 0 {