-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace util.SliceContainsString with slices.Contains & make fmt #1041
Conversation
Signed-off-by: gang.liu <gang.liu@daocloud.io>
…e fmt Signed-off-by: gang.liu <gang.liu@daocloud.io>
…gpt into refact/slices-contains
Welcome @izturn thanks for your contribution! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1041 +/- ##
==========================================
- Coverage 67.24% 67.16% -0.08%
==========================================
Files 30 30
Lines 2549 2543 -6
==========================================
- Hits 1714 1708 -6
Misses 791 791
Partials 44 44 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
welcome! and thanks for clean code.
i left two questions
…gpt into refact/slices-contains
📑 Description
replace util.SliceContainsString with slices.Contains and run
make fmt
✅ Checks
ℹ Additional Information
Signed-off-by: Gang Liu gang.liu@daocloud.io