Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace util.SliceContainsString with slices.Contains & make fmt #1041

Merged
merged 7 commits into from
Apr 19, 2024

Conversation

izturn
Copy link
Contributor

@izturn izturn commented Mar 26, 2024

📑 Description

replace util.SliceContainsString with slices.Contains and run make fmt

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Signed-off-by: Gang Liu gang.liu@daocloud.io

Signed-off-by: gang.liu <gang.liu@daocloud.io>
@izturn izturn requested review from a team as code owners March 26, 2024 06:32
@izturn izturn changed the title chore: use std package's func instead chore: use std package's func instead util/* Mar 26, 2024
@izturn izturn changed the title chore: use std package's func instead util/* refactor: use std package's func instead util/* Mar 26, 2024
@izturn izturn changed the title refactor: use std package's func instead util/* refactor: replace util.SliceContainsString with slices.Contains and run make fmt Mar 26, 2024
@izturn izturn changed the title refactor: replace util.SliceContainsString with slices.Contains and run make fmt refactor: replace util.SliceContainsString with slices.Contains & make fmt Mar 26, 2024
@AlexsJones
Copy link
Member

Welcome @izturn thanks for your contribution!

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.16%. Comparing base (6df0169) to head (e811e14).
Report is 6 commits behind head on main.

❗ Current head e811e14 differs from pull request most recent head b4046dc. Consider uploading reports for the commit b4046dc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1041      +/-   ##
==========================================
- Coverage   67.24%   67.16%   -0.08%     
==========================================
  Files          30       30              
  Lines        2549     2543       -6     
==========================================
- Hits         1714     1708       -6     
  Misses        791      791              
  Partials       44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JuHyung-Son JuHyung-Son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

welcome! and thanks for clean code.
i left two questions

pkg/util/util.go Show resolved Hide resolved
pkg/util/util.go Show resolved Hide resolved
@AlexsJones AlexsJones merged commit 1ae4e75 into k8sgpt-ai:main Apr 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants