-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add minio support #1048
feat: add minio support #1048
Conversation
Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>
Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1048 +/- ##
==========================================
- Coverage 67.24% 67.21% -0.03%
==========================================
Files 30 30
Lines 2549 2550 +1
==========================================
Hits 1714 1714
- Misses 791 792 +1
Partials 44 44 β View full report in Codecov by Sentry. |
Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>
Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>
Closes #1038
π Description
Adding support for minio configs
β Checks
βΉ Additional Information
we first need to release a new buf proto schema
We used to fail fast if region wasn't set, I changed it to support minio by default to point at
us-east-1
a ref: minio/minio#15063