Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add minio support #1048

Merged
merged 5 commits into from
Apr 19, 2024
Merged

Conversation

arbreezy
Copy link
Member

@arbreezy arbreezy commented Mar 30, 2024

Closes #1038

πŸ“‘ Description

Adding support for minio configs

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

we first need to release a new buf proto schema

We used to fail fast if region wasn't set, I changed it to support minio by default to point at us-east-1
a ref: minio/minio#15063

Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>
@arbreezy arbreezy requested review from a team as code owners March 30, 2024 02:19
@arbreezy arbreezy marked this pull request as draft March 30, 2024 02:25
Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>
Copy link

codecov bot commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 67.21%. Comparing base (6df0169) to head (5f5d82a).
Report is 4 commits behind head on main.

❗ Current head 5f5d82a differs from pull request most recent head df662b0. Consider uploading reports for the commit df662b0 to get more accurate results

Files Patch % Lines
pkg/server/config.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1048      +/-   ##
==========================================
- Coverage   67.24%   67.21%   -0.03%     
==========================================
  Files          30       30              
  Lines        2549     2550       +1     
==========================================
  Hits         1714     1714              
- Misses        791      792       +1     
  Partials       44       44              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>
Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>
@arbreezy arbreezy marked this pull request as ready for review April 15, 2024 20:49
@AlexsJones AlexsJones merged commit e6085d4 into k8sgpt-ai:main Apr 19, 2024
7 checks passed
@arbreezy arbreezy deleted the feat/minio-support branch April 19, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature]: On-prem S3 for cache such as Minio
2 participants