Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add keda integration #1058

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

DragonAlex98
Copy link
Contributor

@DragonAlex98 DragonAlex98 commented Apr 7, 2024

Closes #1057

📑 Description

This PR adds the integration for Keda and an analyzer for ScaledObject resources.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@DragonAlex98 DragonAlex98 changed the title feature: add keda integration feat: add keda integration Apr 7, 2024
@DragonAlex98 DragonAlex98 marked this pull request as ready for review April 7, 2024 19:45
@DragonAlex98 DragonAlex98 requested review from a team as code owners April 7, 2024 19:45
pkg/analyzer/events.go Outdated Show resolved Hide resolved
pkg/integration/keda/keda.go Show resolved Hide resolved
@JuHyung-Son
Copy link
Contributor

JuHyung-Son commented Apr 24, 2024

checked it deployed nicely. lgtm.
@DragonAlex98 would you resolve conflict?

Signed-off-by: DragonAlex98 <a.antinori@reply.it>
Signed-off-by: DragonAlex98 <a.antinori@reply.it>
@DragonAlex98
Copy link
Contributor Author

DragonAlex98 commented Apr 24, 2024

Conflicts should now be resolved.

Copy link
Contributor

@JuHyung-Son JuHyung-Son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! greate contribute

@AlexsJones AlexsJones merged commit 9a73d19 into k8sgpt-ai:main Apr 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature]: Add integration for Keda
3 participants