Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Resource Kind in output #1069

Merged
merged 4 commits into from
Apr 20, 2024
Merged

Conversation

panpan0000
Copy link
Contributor

It was very hard to tell the resource type of error object.
I made me hard to deep dive to diagnostic with additional kubectl or other operation .
for example :
Below errors ,I have to guess they are pods:
image
image

But for below , just guess ? a pod again ? No, it's a deployment or statefulset :-)
image

Closes #

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

I use Hi-Yellow , correct me if better color suits.
image

@panpan0000 panpan0000 requested review from a team as code owners April 17, 2024 10:56
@panpan0000 panpan0000 changed the title add Resource Kind in output feat: add Resource Kind in output Apr 17, 2024
Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
@panpan0000
Copy link
Contributor Author

@AlexsJones what do you think about this idea?

@AlexsJones
Copy link
Member

@AlexsJones what do you think about this idea?

I support it

@AlexsJones AlexsJones merged commit aa276a5 into k8sgpt-ai:main Apr 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants