Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: oci genai #1102

Merged
merged 2 commits into from
May 16, 2024
Merged

feat: oci genai #1102

merged 2 commits into from
May 16, 2024

Conversation

anders-swanson
Copy link
Contributor

Closes #1049

πŸ“‘ Description

Adds Oracle Cloud Infrastructure (OCI) GenAI service as a backend for k8sgpt.

βœ… Checks

  • [] My pull request adheres to the code style of this project
  • [] My code requires changes to the documentation
  • [] I have updated the documentation as required
  • [] All the tests have passed

β„Ή Additional Information

CompartmentId is added as a new parameter for OCI GenAI.

@anders-swanson anders-swanson requested review from a team as code owners May 8, 2024 20:36
@anders-swanson anders-swanson changed the title OCI GenAI feat: OCI GenAI May 8, 2024
Copy link
Member

@AlexsJones AlexsJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution! Would you please add an example for this in the README under the

tab and/or a docs contribution also? https://github.com/k8sgpt-ai/docs/issues

@anders-swanson
Copy link
Contributor Author

Thanks for this contribution! Would you please add an example for this in the README under the
tab and/or a docs contribution also? https://github.com/k8sgpt-ai/docs/issues

Hi Alex,
I'll create a docs PR for this feature.

@anders-swanson anders-swanson changed the title feat: OCI GenAI feat: oci genai May 9, 2024
@anders-swanson anders-swanson force-pushed the oci-genai branch 2 times, most recently from 3a6cb3c to 5d742e6 Compare May 9, 2024 13:20
@anders-swanson
Copy link
Contributor Author

semantic checks seem to be passing now, had to force push the branch.

@anders-swanson
Copy link
Contributor Author

@AlexsJones FYI k8sgpt-ai/docs#105

Signed-off-by: Anders Swanson <anders.swanson@oracle.com>
@AlexsJones
Copy link
Member

AlexsJones commented May 14, 2024

More of an FYI, but if you want this to work in the operator there needs to be an addition in the supported backends

@AlexsJones
Copy link
Member

@k8sgpt-ai/k8sgpt-maintainers please review

Copy link
Contributor

@JuHyung-Son JuHyung-Son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't done any actual testing, but the code looks fine. I asked a question I don't know much about OCI.

pkg/ai/ocigenai.go Show resolved Hide resolved
pkg/ai/ocigenai.go Show resolved Hide resolved
@anders-swanson
Copy link
Contributor Author

I haven't done any actual testing, but the code looks fine. I asked a question I don't know much about OCI.

Let me know if you would like to do any OCI testing, I can assist with this.

@anders-swanson
Copy link
Contributor Author

More of an FYI, but if you want this to work in the operator there needs to be an addition in the supported backends

Is this something I update in this repo, or in the operator repo? Having the operator support could be good πŸ‘

@AlexsJones AlexsJones merged commit 047afd4 into k8sgpt-ai:main May 16, 2024
7 checks passed
@anders-swanson anders-swanson deleted the oci-genai branch May 16, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature]: Add Oracle Cloud Infrastructure (OCI) Generative AI Service as a backend
3 participants