feat: add spec.template.spec.securityContext #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ChristianBieri1995 <122007149+ChristianBieri1995@users.noreply.github.com>
JuHyung-Son
reviewed
May 13, 2024
AlexsJones
requested changes
May 14, 2024
Signed-off-by: ChristianBieri1995 <122007149+ChristianBieri1995@users.noreply.github.com>
Signed-off-by: ChristianBieri1995 <122007149+ChristianBieri1995@users.noreply.github.com>
Done, see above. |
Any news on that? Ready to merge? |
JuHyung-Son
reviewed
May 30, 2024
Signed-off-by: ChristianBieri1995 <122007149+ChristianBieri1995@users.noreply.github.com>
AlexsJones
approved these changes
Jun 4, 2024
|
@k8sgpt-ai/k8sgpt-maintainers |
|
Should'nt we have the same logic in the operator too? |
arbreezy
approved these changes
Jun 9, 2024
Would most probably make sense .... |
|
Thanks for your contribution, if you have time please add to the operator @ChristianBieri1995 ! |
AlexsJones
added a commit
to yankay/k8sgpt
that referenced
this pull request
Jul 1, 2024
* feat: add spec.template.spec.securityContext Signed-off-by: ChristianBieri1995 <122007149+ChristianBieri1995@users.noreply.github.com> * make securityContext adjustable Signed-off-by: ChristianBieri1995 <122007149+ChristianBieri1995@users.noreply.github.com> * adjust values.yaml accordingly to enable adjustable securityContext Signed-off-by: ChristianBieri1995 <122007149+ChristianBieri1995@users.noreply.github.com> * Remove default values from securityContext Signed-off-by: ChristianBieri1995 <122007149+ChristianBieri1995@users.noreply.github.com> --------- Signed-off-by: ChristianBieri1995 <122007149+ChristianBieri1995@users.noreply.github.com> Co-authored-by: Aris Boutselis <arisboutselis08@gmail.com> Co-authored-by: Alex Jones <alexsimonjones@gmail.com> Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Description
Adding spec.template.spec.securityContext in order to solve issues when working with Policy Management Tools such as Open Policy Agent and Gatekeeper (as in my case psp-pods-allowed-user-ranges). User and group were taken from https://github.com/k8sgpt-ai/k8sgpt/blob/main/container/Dockerfile#L37. One could also think about adding runAsNonRoot: true and fsGroup: 65532.
✅ Checks
ℹ Additional Information
Even though being more dynamic, other prominent project such as Grafana handle the securityContext in a similar way, see https://github.com/grafana/helm-charts/blob/main/charts/grafana/values.yaml#L142-L146 & https://github.com/grafana/grafana/blob/main/Dockerfile#L106 & https://github.com/grafana/helm-charts/blob/main/charts/grafana/templates/_pod.tpl#L9-L12