feat: getting the error from status field for HPA analyzer #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Signed-off-by: naveenthangaraj03 <tnaveen3402@gmail.com>
Signed-off-by: naveenthangaraj03 <tnaveen3402@gmail.com>
naveenthangaraj03
force-pushed
the
HPA-analyzer
branch
from
bdd001f
to
af1858e
Compare
naveenthangaraj03
changed the title
naveenthangaraj03
changed the title
|
overall looks good! |
|
@JuHyung-Son |
AlexsJones
approved these changes
Jul 8, 2024
AlexsJones
requested changes
Jul 8, 2024
There was a problem hiding this comment.
Please fix these tests
--- FAIL: TestHPAAnalyzerWithUnsuportedScaleTargetRef (0.00s)
hpaAnalyzer_test.go:130: expected error 'does not possible option.' not found in analysis results
--- FAIL: TestHPAAnalyzerWithNonExistentScaleTargetRef (0.00s)
hpaAnalyzer_test.go:177: expected error 'does not exist.' not found in analysis results
assert.go:24: got 0 want 1
Signed-off-by: naveenthangaraj03 <tnaveen3402@gmail.com>
Signed-off-by: naveenthangaraj03 <tnaveen3402@gmail.com>
|
@AlexsJones Can you check this once? |
Signed-off-by: naveenthangaraj03 <tnaveen3402@gmail.com>
Signed-off-by: naveenthangaraj03 <tnaveen3402@gmail.com>
Signed-off-by: naveenthangaraj03 <tnaveen3402@gmail.com>
Signed-off-by: naveenthangaraj03 <tnaveen3402@gmail.com>
|
HI @naveenthangaraj03 ! Tests not worked with your change https://github.com/k8sgpt-ai/k8sgpt/actions/runs/10019909423/job/27696980225?pr=1164 |
Signed-off-by: naveenthangaraj03 <tnaveen3402@gmail.com>
|
@matthisholleville Can you check this now? |
AlexsJones
approved these changes
Jul 20, 2024
kayhern
pushed a commit
to fidelity-contributions/k8sgpt-ai-k8sgpt
that referenced
this pull request
Aug 23, 2024
…#1164) * getting the error from status field for hpa analyzer Signed-off-by: naveenthangaraj03 <tnaveen3402@gmail.com> * Signed-off Signed-off-by: naveenthangaraj03 <tnaveen3402@gmail.com> * Updated the hpaAnalyzer_test.go Signed-off-by: naveenthangaraj03 <tnaveen3402@gmail.com> * Updated hpa_test.go Signed-off-by: naveenthangaraj03 <tnaveen3402@gmail.com> * Updated the hpa Signed-off-by: naveenthangaraj03 <tnaveen3402@gmail.com> * Updated the Conflicts Signed-off-by: naveenthangaraj03 <tnaveen3402@gmail.com> * Resolved all the conflicts Signed-off-by: naveenthangaraj03 <tnaveen3402@gmail.com> * Updated the test case Signed-off-by: naveenthangaraj03 <tnaveen3402@gmail.com> --------- Signed-off-by: naveenthangaraj03 <tnaveen3402@gmail.com> Co-authored-by: Alex Jones <alexsimonjones@gmail.com> Co-authored-by: Matthis <matthish29@gmail.com> Signed-off-by: michael12312 <jun.wang@fmr.com>
AlexsJones
added a commit
that referenced
this pull request
Oct 24, 2024
* getting the error from status field for hpa analyzer Signed-off-by: naveenthangaraj03 <tnaveen3402@gmail.com> * Signed-off Signed-off-by: naveenthangaraj03 <tnaveen3402@gmail.com> * Updated the hpaAnalyzer_test.go Signed-off-by: naveenthangaraj03 <tnaveen3402@gmail.com> * Updated hpa_test.go Signed-off-by: naveenthangaraj03 <tnaveen3402@gmail.com> * Updated the hpa Signed-off-by: naveenthangaraj03 <tnaveen3402@gmail.com> * Updated the Conflicts Signed-off-by: naveenthangaraj03 <tnaveen3402@gmail.com> * Resolved all the conflicts Signed-off-by: naveenthangaraj03 <tnaveen3402@gmail.com> * Updated the test case Signed-off-by: naveenthangaraj03 <tnaveen3402@gmail.com> --------- Signed-off-by: naveenthangaraj03 <tnaveen3402@gmail.com> Co-authored-by: Alex Jones <alexsimonjones@gmail.com> Co-authored-by: Matthis <matthish29@gmail.com> Signed-off-by: AlexsJones <alexsimonjones@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display the error from the status field, will get to know the clear error from the HPA
Closes #
📑 Description
✅ Checks
ℹ Additional Information