Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: auth update throw out exception #1193

Merged
merged 2 commits into from
Jul 18, 2024
Merged

fix: auth update throw out exception #1193

merged 2 commits into from
Jul 18, 2024

Conversation

gyliu513
Copy link
Contributor

@gyliu513 gyliu513 commented Jul 12, 2024 •
edited
Loading

Closes #1194

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@gyliu513 gyliu513 requested review from a team as code owners July 12, 2024 14:53
@gyliu513
fix: auth update throw out exception
8cc2ad4 
Signed-off-by: Guangya Liu <gyliu@ibm.com>
JuHyung-Son
JuHyung-Son approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@JuHyung-Son JuHyung-Son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. thanks

matthisholleville
matthisholleville approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@matthisholleville matthisholleville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexsJones AlexsJones merged commit 391a3cd into k8sgpt-ai:main Jul 18, 2024
8 checks passed
@github-actions github-actions bot mentioned this pull request Jul 18, 2024
Merged
@gyliu513 gyliu513 deleted the update branch July 19, 2024 01:24
@BrewTestBot BrewTestBot mentioned this pull request Aug 4, 2024
Merged
AlexsJones pushed a commit that referenced this pull request Oct 24, 2024
@gyliu513 @matthisholleville @AlexsJones
fix: auth update throw out exception (#1193)
b455119 
Signed-off-by: Guangya Liu <gyliu@ibm.com>
Co-authored-by: Matthis <matthish29@gmail.com>
Signed-off-by: AlexsJones <alexsimonjones@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthisholleville matthisholleville matthisholleville approved these changes

@JuHyung-Son JuHyung-Son JuHyung-Son approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: k8s auth update report exception
4 participants
@gyliu513 @JuHyung-Son @matthisholleville @AlexsJones