Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add providerId to serve mode #1260

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

liyanwei93
Copy link
Contributor

@liyanwei93 liyanwei93 commented Sep 27, 2024

Closes #

📑 Description

In the ibmwatsonxai AI backend, it requires providerId and it is indispensable. Refer to PR. Therefore, we need to add providerId parameter in the serve mode so that we can enable ibmwatsonxai in k8sgpt-operator to pass the providerId parameters.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@liyanwei93 liyanwei93 requested review from a team as code owners September 27, 2024 00:04
@liyanwei93 liyanwei93 changed the title Add providerId to serve mode fix: Add providerId to serve mode Sep 27, 2024
@liyanwei93 liyanwei93 changed the title fix: Add providerId to serve mode fix: add providerId to serve mode Sep 27, 2024
Signed-off-by: yanweili <yanweili@ibm.com>
Copy link
Contributor

@gyliu513 gyliu513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@AlexsJones can you help review? Thanks!

@AlexsJones AlexsJones merged commit da0764d into k8sgpt-ai:main Sep 27, 2024
11 checks passed
AlexsJones pushed a commit that referenced this pull request Oct 24, 2024
Signed-off-by: yanweili <yanweili@ibm.com>
Co-authored-by: yanweili <yanweili@ibm.com>
Signed-off-by: AlexsJones <alexsimonjones@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants