Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Ingress class validation #154

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

matthisholleville
Copy link
Contributor

Closes #

📑 Description

The commit adds functionality to validate whether the Ingress resource specifies a valid Ingress class or not. If no Ingress class is specified, a message will be returned indicating that an Ingress class needs to be specified. If an Ingress class is specified, the code will validate whether it exists or not.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Signed-off-by: Matthis Holleville <matthish29@gmail.com>
@matthisholleville matthisholleville requested a review from a team as a code owner March 30, 2023 11:41
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thschue thschue merged commit b061566 into k8sgpt-ai:main Mar 30, 2023
fyuan1316 pushed a commit to fyuan1316/k8sgpt that referenced this pull request Jun 26, 2023
….0 (k8sgpt-ai#154)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants