Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add --auth-string flag to auth #180

Closed
3 of 4 tasks
shivamdurgbuns opened this issue Apr 1, 2023 · 6 comments · Fixed by #199
Closed
3 of 4 tasks

feature: add --auth-string flag to auth #180

shivamdurgbuns opened this issue Apr 1, 2023 · 6 comments · Fixed by #199
Assignees

Comments

@shivamdurgbuns
Copy link

shivamdurgbuns commented Apr 1, 2023

Checklist:

  • I've searched for similar issues and couldn't find anything matching
  • I've discussed this feature in the #k8sgpt slack channel

Is this feature request related to a problem?

  • Yes
  • No

Upon usage I have seen that in order to provide the API key using auth command we have to pass input to the prompted line

Describe the solution you'd like

I am suggesting to have an extra flag names --auth-string, that could be used to provide API to auth command into the same line.

Benefits for the project and its users

This will benefit in places such as CI/CD or any scripts where we have to single the key in the same single line command rather than waiting for input, we can directly pass the secret in the same line.

@shivamdurgbuns
Copy link
Author

I would be working on this one, so please assign it to me. Thank you :)

@AlexsJones
Copy link
Member

I think this could be useful, thanks I will add it to the issue backlog

@AlexsJones
Copy link
Member

I would recommend we use something more standard like --password-from-stdin or --password

@matthisholleville
Copy link
Contributor

@shivamdurgbuns I am working on an integration with GitLab CI, so I also needed this functionality. I have submitted a merge request. I hope you haven't started anything on your end? 😞

@shivamdurgbuns
Copy link
Author

@shivamdurgbuns I am working on an integration with GitLab CI, so I also needed this functionality. I have submitted a merge request. I hope you haven't started anything on your end? 😞

Oh! I had started working on, but your pr looks ok. You should have waited a little I was about to test and push those changes.

@matthisholleville
Copy link
Contributor

Sorry. I'll contact you upstream next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants