Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: analyzer and ai interfacing #200

Merged
merged 6 commits into from
Apr 5, 2023
Merged

chore: analyzer and ai interfacing #200

merged 6 commits into from
Apr 5, 2023

Conversation

thschue
Copy link
Contributor

@thschue thschue commented Apr 3, 2023

📑 Description

  • Create Interface for AI providers
  • Move analyzers to folders
  • Restructure analyzers a bit
  • Separate analyzers and analysis

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@thschue thschue marked this pull request as ready for review April 3, 2023 06:38
@thschue thschue requested a review from a team as a code owner April 3, 2023 06:38
@AlexsJones
Copy link
Member

I like the signature change of the analyzers but I personally dislike the foldering of each analyzer, it feels unnecessary without evident gain

matthisholleville
matthisholleville reviewed Apr 3, 2023
View reviewed changes
cmd/analyze/analyze.go Outdated Show resolved Hide resolved
pkg/ai/iai.go Show resolved Hide resolved
@thschue
Copy link
Contributor Author

thschue commented Apr 4, 2023

I like the signature change of the analyzers but I personally dislike the foldering of each analyzer, it feels unnecessary without evident gain

I moved the analyzers back to a single folder.

@matthisholleville matthisholleville requested a review from a team April 4, 2023 12:01
@thschue
chore: analyzer and ai interfacing
c6a4b9f 
Signed-off-by: Thomas Schuetz <thomas.schuetz@t-sc.eu>
@thschue
fix: backend variable for aiProvider in cmd
8b8ebe9 
Signed-off-by: Thomas Schuetz <thomas.schuetz@t-sc.eu>
@thschue
fix: changed folders for analyzers
be5faba 
Signed-off-by: Thomas Schuetz <thomas.schuetz@t-sc.eu>
@thschue
chore: renamed analyzers
9058813 
Signed-off-by: Thomas Schuetz <thomas.schuetz@t-sc.eu>
@thschue
fix: fixed ingress tests after rebase
4243c0e 
Signed-off-by: Thomas Schuetz <thomas.schuetz@t-sc.eu>
@thschue
fix: fixed ingress tests after rebase
cf92013 
Signed-off-by: Thomas Schuetz <thomas.schuetz@t-sc.eu>
@thschue thschue enabled auto-merge (squash) April 5, 2023 06:01
@thschue thschue merged commit 0195bfa into main Apr 5, 2023
@thschue thschue deleted the feat/interfaces_contd branch April 5, 2023 06:40
@github-actions github-actions bot mentioned this pull request Apr 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexsJones AlexsJones AlexsJones approved these changes

@matthisholleville matthisholleville matthisholleville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thschue @AlexsJones @matthisholleville