-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Support for remote cache #209
Comments
I thought about this during implementation and agree in principal. Will think on it some more and add into the project backlog, thank you! |
I would like to propose a first implementation. Have you started something about this @AlexsJones ? |
I haven't started anything, can you outline what you're thinking? |
I think this issue needs to be split into two feature requests:
What do you think? |
I think S3 can be set to do the locking for you? |
Yes we could use this solution I think : https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-lock.html . But this solution does not work in the same way with all remote backends ( gcs, git, etc... ). Shouldn't we use a generic solution for all backends like terraform does ? |
Looking at a User story, I believe Terraform and k8sgpt are used in different ways that might require different approaches here. From my point of view at least, terraform is often used during CI for resource management and the lock makes sense because this really prevents a possible outage if not present. Now pardon my lack of knowledge about k8sgpt internals, but what is the worst case possible if the cache doesn't have a lock during updates 😅? It shouldn't be able to actually make changes to a cluster, so although not the best UX, it is not able to cause outages right? |
Thank you for your answer. It's a good question to ask. From my understanding we need a lock or mechanism to ensure that the cache is not corrupted when parallelizing the analyses. |
I am doing some work on designing this, will update here when I have something we can discuss further. |
Not sure if it's helpful, but you might want to see https://github.com/replicatedhq/troubleshoot, which has a The short story is, you can grab a totally disconnected tarball from a cluster, ship it somewhere, and then serve it up and run kubectl commands against it without having to connect to the live cluster. Handy if you're doing disconnected support work. I'd love to get k8sgpt to read those bundles. |
I think the support bundle is an interesting idea, we do it in microk8s and it's really useful. I think there are two interesting requirements for this work
That second item I think is worthy of its own design discussion to take it further. |
Related to #381 |
Remove will be supported as of v0.3.3, thanks for the suggestion ❤️ |
Checklist:
Is this feature request related to a problem?
Describe the solution you'd like
It would be nice if k8sgpt had the option to cache remotely.
Benefits for the project and its users
With multiple individuals responsible for the same cluster/clusters, e.g. employees in the same company, a remote cache can decrease costs and latency if all those employees use the same cache.
Potential drawbacks
Additional context
The text was updated successfully, but these errors were encountered: