Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: improve HPA analyzer to check if ScaleTargetRef have ressources configured #261

Closed
2 of 4 tasks
matthisholleville opened this issue Apr 13, 2023 · 4 comments · Fixed by #283
Closed
2 of 4 tasks
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@matthisholleville
Copy link
Contributor

Checklist:

  • I've searched for similar issues and couldn't find anything matching
  • I've discussed this feature in the #k8sgpt slack channel

Is this feature request related to a problem?

  • Yes
  • No

Describe the solution you'd like

To improve HPA analyzer, I would suggest implementing a feature that checks if the ScaleTargetRef for a deployment has resource configured. This feature would ensure that the HPA is correctly configured.

Benefits for the project and its users

Improving HPA to check if ScaleTargetRef have resource configured would help ensure that deployments are scaled appropriately and prevent potential scaling issues.

@matthisholleville matthisholleville changed the title feature: improve HPA analyzer to check if ScaleTargetRef have ressource configured feature: improve HPA analyzer to check if ScaleTargetRef have ressources configured Apr 13, 2023
@rakshitgondwal
Copy link
Member

Hey @matthisholleville! I would like to work on this.

@matthisholleville
Copy link
Contributor Author

Let's Go 🤩

@rakshitgondwal
Copy link
Member

Thank you for assigning me this @matthisholleville!
Just confirming that in this feature, we'll check if either one of Resource.Requests or Resource.Limit has not been configured right?

@matthisholleville
Copy link
Contributor Author

Yes, I think that's a good first step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants