feat: async calls #311
Merged
feat: async calls #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
|
Great job, Alex! It looks like the client is experiencing a bit of throttling on one of my clusters with 100 namespaces and 500 deployments: I0421 09:04:25.405611 32626 request.go:690] Waited for 1.128472333s due to client-side throttling, not priority and fairness, request: GET:...To avoid this warning and prevent overloading the Kubernetes server, should we consider using channels to synchronize our Go routines? This will help us wait for the completion of each request before sending another. |
|
Ill take a look using a buffered channel |
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
matthisholleville
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
📑 Description
✅ Checks
ℹ Additional Information