fix: take KUBECONFIG env variable into consideration
#340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickpichler
force-pushed
the
fix/332/kubeconfig-env-not-considered
branch
2 times, most recently
from
d6cae31
to
b49535c
Compare
|
Mhmm to really test it, we would need some kind of end to end testing I guess. In general, Tbh I would create a ticket for it though, as this needs some more thought put into it 🙂 |
AlexsJones
approved these changes
Apr 26, 2023
Before, the default value set for the `--kubeconfig` flag prevented the `KUBECONFIG` env variable to be ever taken into consideration. This behavior has now been fixed. If `--kubeconfig` flag is set, it takes precedence over the `KUBECONFIG` env variable. fixes k8sgpt-ai#331 Signed-off-by: Patrick Pichler <git@patrickpichler.dev>
patrickpichler
force-pushed
the
fix/332/kubeconfig-env-not-considered
branch
from
b49535c
to
0b4e927
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #331
📑 Description
Before, the default value set for the
--kubeconfigflag prevented theKUBECONFIGenv variable to be ever taken into consideration. Thisbehavior has now been fixed.
If
--kubeconfigflag is set, it takes precedence over theKUBECONFIGenvvariable.
✅ Checks
ℹ Additional Information