Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Help wanted: Bring Trivy integration settings into config #359

Closed
2 tasks done
AlexsJones opened this issue Apr 28, 2023 · 7 comments · Fixed by #797
Closed
2 tasks done

[Feature]: Help wanted: Bring Trivy integration settings into config #359

AlexsJones opened this issue Apr 28, 2023 · 7 comments · Fixed by #797
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@AlexsJones
Copy link
Member

Checklist

  • I've searched for similar issues and couldn't find anything matching
  • I've discussed this feature request in the K8sGPT Slack and got positive feedback

Is this feature request related to a problem?

No

Problem Description

Currently the settings for the Trivy integration as hard coded here


const (
	Repo          = "https://aquasecurity.github.io/helm-charts/"
	Version       = "0.13.0"
	ChartName     = "trivy-operator"
	RepoShortName = "aqua"
	ReleaseName   = "trivy-operator-k8sgpt"
)

Solution Description

We should have an ability to control this outside of the code - potentially as part of the default config ( we could inject it on first run, but let users override )

I am not suggesting a solution but identifying an area for improvement.

Benefits

This would enable version to be incremented without requiring a rebuild of K8sGPT

Potential Drawbacks

No response

Additional Information

No response

@AlexsJones AlexsJones added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Apr 28, 2023
@briannd81
Copy link

I would like to tackle this issue. How do I assign to myself?

@AlexsJones
Copy link
Member Author

@briannd81 I'll assign you thanks!

@ShivangShandilya
Copy link

hey @briannd81 are you still working on this issue? If not I would like to take a look at it

@AlexsJones
Copy link
Member Author

Please feel free @ShivangShandilya

@rohannair11
Copy link

rohannair11 commented Aug 7, 2023

I would like to try and solve this issue if it's still open.
Also, does it involve manipulating the type present in the trivy.go file ? If so, How can i go about injecting it via a default config file? I'm quite new to this project.

@ShivangShandilya
Copy link

hey @rohannair11 if you want we can both work on this issue together, I'm still exploring the project and would be amazing if we can do something together

@rohannair11
Copy link

hey @rohannair11 if you want we can both work on this issue together, I'm still exploring the project and would be amazing if we can do something together

ofcourse! I would love to learn more about this project too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants