Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rework output format #368

Merged

Conversation

matthisholleville
Copy link
Contributor

@matthisholleville matthisholleville commented May 2, 2023

Closes #325

📑 Description

I have revamped the error handling to ensure that they are included and adhere to the output format. Now we have an errors attribute in the Analysis object that collects all the errors and displays them based on the output selected by the user.

I also deleted some not useful logs on configuration management

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Signed-off-by: Matthis Holleville <matthish29@gmail.com>
@matthisholleville matthisholleville requested review from a team as code owners May 2, 2023 11:34
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
matthisholleville and others added 3 commits May 2, 2023 19:45
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
This reverts commit 1a3cfa8.

Signed-off-by: Matthis Holleville <matthish29@gmail.com>
@AlexsJones AlexsJones merged commit 8b49f70 into k8sgpt-ai:main May 3, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

question: -o json is not returning an entire json structure for some cases
2 participants