Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add auth commands #369

Merged
merged 7 commits into from
May 5, 2023
Merged

Conversation

HatiCode
Copy link
Contributor

@HatiCode HatiCode commented May 2, 2023

📑 Description

Initiated a change on the auth command the follow the style of "filter"
This allows for now to:

  • list the configured providers
  • Add a new provider configuration

Still needed (If PR is accepted an issue for this will be created):

  • possibility to update a previously configured provider

Older Flags are now defined in the "new" command.
Creating a provider would look like:

k8sgpt auth new -b -m -p -u

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Signed-off-by: Alexandre Steppé <alexandre.steppe@gmail.com>
Signed-off-by: Alexandre Steppé <alexandre.steppe@gmail.com>
Signed-off-by: Alexandre Steppé <alexandre.steppe@gmail.com>
@HatiCode HatiCode requested review from a team as code owners May 2, 2023 14:01
@HatiCode HatiCode changed the title Feat: add auth commands feat: add auth commands May 2, 2023
Signed-off-by: Alexandre Steppé <alexandre.steppe@gmail.com>
@AlexsJones
Copy link
Member

It feels quite nice to separate these out, I would ask you update the documentation in the README and the docs page though

Copy link
Member

@AlexsJones AlexsJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the README

Signed-off-by: Alexandre Steppé <alexandre.steppe@gmail.com>
Signed-off-by: Alexandre Steppé <alexandre.steppe@gmail.com>
@HatiCode HatiCode requested a review from AlexsJones May 4, 2023 20:58
@AlexsJones AlexsJones merged commit 00aaae8 into k8sgpt-ai:main May 5, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants