Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Enhance Auth command #388

Closed
2 tasks done
HatiCode opened this issue May 7, 2023 · 3 comments · Fixed by #450
Closed
2 tasks done

[Feature]: Enhance Auth command #388

HatiCode opened this issue May 7, 2023 · 3 comments · Fixed by #450
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@HatiCode
Copy link
Contributor

HatiCode commented May 7, 2023

Checklist

  • I've searched for similar issues and couldn't find anything matching
  • I've discussed this feature request in the K8sGPT Slack and got positive feedback

Is this feature request related to a problem?

No

Problem Description

Auth could allow the user to update a previously configured provider. At the moment "auth" allows to list providers or add a new one.
Also, there's no background check on the validity of a configured key.

Solution Description

  • add an update subcommand to the auth command
  • Run a background check on the the key provided towards configured provider

Benefits

  • Allow to modify a configured provider
  • Make sure a provided key is valid if not generated through generate command

Potential Drawbacks

No response

Additional Information

No response

@HatiCode
Copy link
Contributor Author

HatiCode commented May 7, 2023

@AlexsJones Can I be assigned to this one ?

@matthisholleville matthisholleville added enhancement New feature or request good first issue Good for newcomers labels May 8, 2023
@AlexsJones
Copy link
Member

Hey @HatiCode how are you getting on with this?

@HatiCode
Copy link
Contributor Author

HatiCode commented May 22, 2023

@AlexsJones I worked on this yesterday, I'll push a draft PR today but I'm facing a small issue right now I'm not able to apply a change to a single key and keep the rest as it is. That's because the flags apply the default value when writing config. Maybe you or @matthisholleville can help with this since I noticed you refactored some of the existing code already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants