feat: filters api #407
Merged
feat: filters api #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit fixes the issue where the RunAnalysis() function continues execution even after matching a condition. The fix ensures that the execution stops at the end of the corresponding if statement, improving the control flow and preventing unnecessary processing. Signed-off-by: Matthis Holleville <matthish29@gmail.com>
The commit introduces a new feature where the filters parameter is included in the initialization of the AnalyzeRequest. This enhancement allows for more specific analysis by specifying filters during the analysis process. Signed-off-by: Matthis Holleville <matthish29@gmail.com>
4 tasks
AlexsJones
approved these changes
May 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
📑 Description
This pull request includes two commits that address different aspects of the codebase:
RunAnalysis()This commit fixes an issue in the
RunAnalysis()function where the execution continued even after matching a condition. With this fix, the execution now stops at the end of the corresponding if statement, improving control flow.AnalyzeRequestinitializationThis commit adds a new feature to the
AnalyzeRequestinitialization. It includes the filters parameter, allowing for more specific analysis by specifying filters during the analysis process.✅ Checks
ℹ Additional Information
grpcurl -plaintext -d '{"explain": false, "nocache": false, "filters": ["Ingress"], "namespace": "k8sgpt"}' localhost:8080 schema.v1.Server/Analyze