Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: gofmt fix and enable in CI #414

Merged
merged 3 commits into from
May 15, 2023
Merged

Conversation

panpan0000
Copy link
Contributor

@panpan0000 panpan0000 commented May 15, 2023

Closes #NA

πŸ“‘ Description

Fix some files detected by make fmt
Add make test and make fmt into Github Action. make lint is not added until all lint problems fixed(refer to comment in #405)

βœ… Checks

  • My pull request adheres to the code style of this project
  • [NA] My code requires changes to the documentation
  • [NA] I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
@panpan0000 panpan0000 requested review from a team as code owners May 15, 2023 01:19
@panpan0000
Copy link
Contributor Author

@cubxxw can you please help to review, as a CI expert ?

I'm not sure if the make command will work in Github Action (but seems no way to test it unless merge it), can you help me to confirm ?

thank you so much.

Copy link
Contributor

@cubxxw cubxxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panpan0000
Of course, there's no problem with unit tests, and we might need to add a test coverage later on. The Fmt isn't particularly elegant, and the cicd seems to just skip the actions and pass.

@AlexsJones AlexsJones merged commit e66de8c into k8sgpt-ai:main May 15, 2023
5 checks passed
@panpan0000
Copy link
Contributor Author

panpan0000 commented May 15, 2023

Thanks for both of you...
@cubxxw:

  1. about the reason why the fmt pass , all files are align with gofmt, so make gofmt returns nothing. Am I right ?
  2. Can you help about how to refine the checking for make fmt. you are right, my code looks ugly...

@cubxxw
Copy link
Contributor

cubxxw commented May 15, 2023

Thanks for both of you... @cubxxw:

  1. about the reason why the fmt pass , all files are align with gofmt, so make gofmt returns nothing. Am I right ?
  2. Can you help about how to refine the checking for make fmt. you are right, my code looks ugly...

Since there is no change in itself, make fmt may be due to nothing being executed, so there is no corresponding, and you are right.

I will keep this in mind later in the design of the CICD stream. Thank you for trusting me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants