fix: optimize analyze service #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleverhu
force-pushed
the
optimize-analyze-service
branch
from
c1c2e90
to
aa9f86c
Compare
|
Hello @cleverhu, thank you very much for your contribution. Do we really need to have this information? Shouldn't we just proceed ( |
Yes, I think it is correct to omit any debugging information from the output. |
cleverhu
force-pushed
the
optimize-analyze-service
branch
from
aa9f86c
to
8b5b1c4
Compare
Signed-off-by: cleverhu <shouping.hu@daocloud.io> Signed-off-by: cleverhu <zhubai.hsp@xuelanyun.com>
cleverhu
force-pushed
the
optimize-analyze-service
branch
from
8b5b1c4
to
a6a9644
Compare
|
Yay another first time contributor - welcome! Is this read for review again? |
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
📑 Description
When I used the analysis command, I found that the yellow error 'Service kube system/cluster. local nfs client nfs sub dir external advisor does not exist' was reported such as:
However, during my investigation, I found that the purpose of this endpoint is not to discover the pod IP, but to act as a leaderAction. Therefore, I believe this should not be thrown as a yellow warning.
✅ Checks
ℹ Additional Information