fix: displaying correct yaml config location on app start #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a5w
changed the title
Signed-off-by: Ali Mohsin <aliofthemohsins@gmail.com>
AlexsJones
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
Thanks for this @a5w ! Welcome 🥇 we love first time contributors
AlexsJones
added a commit
that referenced
this pull request
Jun 26, 2023
Signed-off-by: Ali Mohsin <aliofthemohsins@gmail.com> Co-authored-by: Alex Jones <alexsimonjones@gmail.com>
AlexsJones
added a commit
that referenced
this pull request
Jun 29, 2023
* feat: upgrading azure client impl Signed-off-by: Alex Jones <alexsimonjones@gmail.com> * feat: upgrading azure client impl Signed-off-by: Alex Jones <alexsimonjones@gmail.com> * fix: displaying correct yaml config location on app start (#521) Signed-off-by: Ali Mohsin <aliofthemohsins@gmail.com> Co-authored-by: Alex Jones <alexsimonjones@gmail.com> * fix(deps): update module github.com/aws/aws-sdk-go to v1.44.289 (#524) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat: upgrading azure client impl Signed-off-by: Alex Jones <alexsimonjones@gmail.com> --------- Signed-off-by: Alex Jones <alexsimonjones@gmail.com> Signed-off-by: Ali Mohsin <aliofthemohsins@gmail.com> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Ali Mohsin <aliofthemohsins@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
📑 Description
On app start it shows default config file location as $HOME/.k8sgpt.yaml which is different for different OS.
I've updated the code to show the correct location according to users OS on app start.
✅ Checks
ℹ Additional Information
OLD
New
