Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]: Deleting a provider should remove it if default #527

Closed
3 of 4 tasks
AlexsJones opened this issue Jun 26, 2023 · 3 comments · Fixed by #529
Closed
3 of 4 tasks

[bug]: Deleting a provider should remove it if default #527

AlexsJones opened this issue Jun 26, 2023 · 3 comments · Fixed by #529
Assignees
@rakshitgondwal
Labels
backend bug Something isn't working enhancement New feature or request good first issue Good for newcomers

Comments

@AlexsJones
Copy link
Member

Checklist

  • I've searched for similar issues and couldn't find anything matching
  • I've included steps to reproduce the behavior

Affected Components

  • K8sGPT (CLI)
  • K8sGPT Operator

K8sGPT Version

v0.3.8

Kubernetes Version

v.1.26

Host OS and its Version

No response

Steps to reproduce

  1. Add an azure provider
  2. Set as the default e.g. k8sgpt auth default -p azureopenai
  3. k8sgpt auth remove azureopenai
  4. see that the provider is still listed as default

Expected behaviour

The provider should no longer be default

Actual behaviour

No response

Additional Information

No response
@AlexsJones AlexsJones added bug Something isn't working enhancement New feature or request good first issue Good for newcomers backend labels Jun 26, 2023
@rakshitgondwal
Copy link
Member

Can I work on this? @AlexsJones

@rakshitgondwal
Copy link
Member

rakshitgondwal commented Jun 26, 2023 •
edited

Suppose once the azureopenai provider gets deleted, we want to set the default provider back to openai right? @AlexsJones

@AlexsJones
Copy link
Member Author

Yeah OpenAI as default

@rakshitgondwal rakshitgondwal mentioned this issue Jun 26, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rakshitgondwal rakshitgondwal

Labels
backend bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove provider from default on delete rakshitgondwal/k8sgpt
2 participants
@AlexsJones @rakshitgondwal