Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add details flag to auth list command #537

Merged
merged 3 commits into from
Jul 3, 2023

Conversation

HatiCode
Copy link
Contributor

@HatiCode HatiCode commented Jun 30, 2023

📑 Description

Since the refactor of list.go, the list command prints out the default/active/inactive providers based on the available & supported backends. The --details flags allows to print the current config details for each active backend based on the elements present in the config file. This further helps the use of the update command and allows better visibility on a current config ( no need to go and read the config file ).

Screenshot 2023-06-30 at 09 47 25 Screenshot 2023-06-30 at 09 48 30

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

--details allows to choose whether to print out the password or not. This could be removed if judged overkill.

Signed-off-by: Alexandre Steppé <alexandre.steppe@gmail.com>
@HatiCode HatiCode requested review from a team as code owners June 30, 2023 07:49
Copy link
Member

@AlexsJones AlexsJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great life improvement thanks!

@AlexsJones AlexsJones merged commit 2309b0d into k8sgpt-ai:main Jul 3, 2023
7 checks passed
@HatiCode HatiCode deleted the feat/add-list-details branch July 3, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants