Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use-case while in cluster, connecting to an external #623

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

arbreezy
Copy link
Member

Closes #604

📑 Description

There is a use case where people will run k8sgpt within a management cluster, as a pivot to other clusters where they can define explicitly the kubeconfig.
This small PR hopefully addresses that case by ensuring whenever kubeconfig is defined we will use it to create the k8s client even if k8sgpt is running in a cluster

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>
@arbreezy arbreezy requested review from a team as code owners August 31, 2023 18:41
@AlexsJones AlexsJones enabled auto-merge (squash) September 1, 2023 08:09
@AlexsJones AlexsJones merged commit 1a7f45c into k8sgpt-ai:main Sep 1, 2023
1 check passed
@arbreezy arbreezy deleted the fix/in-cluster-with-kubeconfig branch September 1, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug]: --kubeconfig doesn't work
2 participants