Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rework cache package - add gcs cache - add cache purge command #750

Merged
merged 13 commits into from
Nov 18, 2023
Merged

feat: rework cache package - add gcs cache - add cache purge command #750

merged 13 commits into from
Nov 18, 2023

Conversation

matthisholleville
Copy link
Contributor

@matthisholleville matthisholleville commented Nov 13, 2023 •
edited
Loading

📑 Description

  • Cache package rework
  • Added GCS as a cache provider
  • Added the cache object purge command
  • Improved the output of the k8sgpt cache list command

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

The cache package rework enables the integration of other providers without conflicts in option naming. For example, the integration of GCS and S3 uses the same options (bucketName & Region), which made GCS integration impossible before the rework.

The server mode has been tested with the k8sgpt-ai/schemas#19 branch available on buf.build.

The k8sgpt cache list command now returns a table, which makes it easier for users to read.

(matthisholleville) ➜  k8sgpt git:(feat/rework-cache) ✗ ./bin/k8sgpt cache list                                                                  
+------------------------------------------------------------------+-------------------------------+
|                               NAME                               |           UPDATEDAT           |
+------------------------------------------------------------------+-------------------------------+
| 02111dd651b326313a1d79097ae213d71287beed3a8217f0026e0efab7363d7d | 2023-11-13 12:56:50 +0000 UTC |
+------------------------------------------------------------------+-------------------------------+

The k8sgpt cache purge command allows you to delete an object from the cache (local or remote). A future improvement could allow for the deletion of multiple or all cache objects.

@matthisholleville
feat: rework cache pkg
210e43c 
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
@matthisholleville
feat: Completion of cache pkg rework. Added cache purge command.
8aedb94 
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
@matthisholleville matthisholleville changed the title !feat: rework cache package - add gcs cache - add cache purge command feat: rework cache package - add gcs cache - add cache purge command Nov 13, 2023
@matthisholleville
doc: add purgin command note
0551429 
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
@matthisholleville
fix: disable cache if noCache is set
f977c8b 
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
@matthisholleville
feat: improve GetCacheConfiguration lisibility & transform add method…
a7e79d5 
… to addOrUpdate

Signed-off-by: Matthis Holleville <matthish29@gmail.com>
@matthisholleville
feat: transform server mode to work with new cache configuration
8a74ef4 
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
@matthisholleville matthisholleville mentioned this pull request Nov 14, 2023
Merged
4 tasks
@matthisholleville
fix: use 'switch' instead 'if' to evaluate Cache from grpc
ea9975f 
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
@matthisholleville matthisholleville mentioned this pull request Nov 15, 2023
Merged
4 tasks
@matthisholleville matthisholleville marked this pull request as ready for review November 15, 2023 00:14
AlexsJones
AlexsJones reviewed Nov 15, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@matthisholleville
feat: add mutually exclusive flags for command options
50dadd2 
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
@matthisholleville
doc: update readme.md
a2fef44 
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
@matthisholleville
feat: return err on bucket creation failed
ce866b7 
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
arbreezy
arbreezy approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@arbreezy arbreezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work

AlexsJones
AlexsJones requested changes Nov 16, 2023
View reviewed changes
pkg/cache/gcs_based.go Show resolved Hide resolved
pkg/cache/gcs_based.go Show resolved Hide resolved
pkg/cache/gcs_based.go Show resolved Hide resolved
pkg/cache/gcs_based.go Show resolved Hide resolved
pkg/cache/s3_based.go Show resolved Hide resolved
pkg/cache/s3_based.go Show resolved Hide resolved
@matthisholleville
feat: update dependencies
5a11a8e 
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
@matthisholleville
Merge branch 'main' into feat/rework-cache
544958e 
Signed-off-by: Matthis <matthish29@gmail.com>
@matthisholleville matthisholleville merged commit 12146bf into k8sgpt-ai:main Nov 18, 2023
7 checks passed
@github-actions github-actions bot mentioned this pull request Nov 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexsJones AlexsJones AlexsJones approved these changes

@arbreezy arbreezy arbreezy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthisholleville @AlexsJones @arbreezy