Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cover more error reason messages #759

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

jmyung
Copy link
Contributor

@jmyung jmyung commented Nov 17, 2023

Closes #758

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

@jmyung jmyung requested review from a team as code owners November 17, 2023 11:05
@jmyung jmyung changed the title cover more error reasons fix: cover more error reasons Nov 17, 2023
Signed-off-by: Jesang Myung <jesang.myung@gmail.com>
@jmyung jmyung changed the title fix: cover more error reasons fix: cover more error reason messages Nov 17, 2023
pkg/analyzer/pod.go Outdated Show resolved Hide resolved
Signed-off-by: Jesang Myung <jesang.myung@gmail.com>
Copy link
Member

@AlexsJones AlexsJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ie thanks @jmyung

@AlexsJones AlexsJones enabled auto-merge (squash) November 18, 2023 20:56
@AlexsJones AlexsJones enabled auto-merge (rebase) November 18, 2023 20:56
@AlexsJones AlexsJones enabled auto-merge (squash) November 20, 2023 12:25
@AlexsJones AlexsJones enabled auto-merge (squash) November 20, 2023 12:25
@AlexsJones
Copy link
Member

@jmyung thanks for the PR, if you can update the branch we can merge it in

@AlexsJones AlexsJones merged commit 5b27c3e into k8sgpt-ai:main Nov 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature]: Need to cover more error reason messages.
3 participants