Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added basic server startup test #817

Merged
merged 3 commits into from
Dec 29, 2023
Merged

chore: added basic server startup test #817

merged 3 commits into from
Dec 29, 2023

Conversation

AlexsJones
Copy link
Member

This PR is in response to #809

Closes #

πŸ“‘ Description

βœ… Checks

  • [ x] My pull request adheres to the code style of this project
  • [ x] My code requires changes to the documentation
  • [ x] I have updated the documentation as required
  • [x ] All the tests have passed

β„Ή Additional Information

Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
@AlexsJones AlexsJones requested review from a team as code owners December 29, 2023 11:59
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (fcd29a5) 52.36% compared to head (c589976) 46.53%.

Files Patch % Lines
pkg/server/server.go 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #817      +/-   ##
==========================================
- Coverage   52.36%   46.53%   -5.83%     
==========================================
  Files          22       27       +5     
  Lines        1925     2196     +271     
==========================================
+ Hits         1008     1022      +14     
- Misses        882     1137     +255     
- Partials       35       37       +2     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@AlexsJones AlexsJones merged commit 3e7cea7 into main Dec 29, 2023
9 of 11 checks passed
@AlexsJones AlexsJones deleted the chore/server_test branch December 29, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant