Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no explain case, improved readability. #825

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

bwplotka
Copy link
Contributor

@bwplotka bwplotka commented Jan 3, 2024

πŸ“‘ Description

k8sgpt analyze (without explain) is not working due to lack of AI provider. This was weird to me given enable AI setting in k8s operator exists (probably not working due to this issue as well). I assume no --explain means no AI should be touched.

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@bwplotka bwplotka requested review from a team as code owners January 3, 2024 16:38
@bwplotka bwplotka changed the title analyze: Fixed no explain case, improved readability. fix(analyze): Fixed no explain case, improved readability. Jan 3, 2024
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (70c6892) 46.58% compared to head (7969c9a) 46.54%.

Files Patch % Lines
pkg/analysis/analysis.go 0.00% 37 Missing ⚠️
pkg/analysis/output.go 0.00% 6 Missing ⚠️
pkg/server/analyze.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #825      +/-   ##
==========================================
- Coverage   46.58%   46.54%   -0.05%     
==========================================
  Files          27       27              
  Lines        2196     2198       +2     
==========================================
  Hits         1023     1023              
- Misses       1135     1137       +2     
  Partials       38       38              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@thschue thschue changed the title fix(analyze): Fixed no explain case, improved readability. fix: Fixed no explain case, improved readability. Jan 3, 2024
@thschue thschue changed the title fix: Fixed no explain case, improved readability. fix: no explain case, improved readability. Jan 3, 2024
Signed-off-by: bwplotka <bwplotka@gmail.com>
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution! LGTM

@thschue thschue merged commit 035348d into k8sgpt-ai:main Jan 3, 2024
7 of 9 checks passed
@bwplotka bwplotka deleted the explain branch January 3, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants