Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unify aiClientName const for all providers #848

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

matthisholleville
Copy link
Contributor

@matthisholleville matthisholleville commented Jan 7, 2024

πŸ“‘ Description

GoogAI PR has added a new constant to determine the AI client name. This PR unifies and adds a new constant to determine the AI client name on all providers.

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Signed-off-by: Matthis Holleville <matthish29@gmail.com>
@matthisholleville matthisholleville requested review from a team as code owners January 7, 2024 10:19
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@matthisholleville matthisholleville merged commit 5c17c24 into k8sgpt-ai:main Jan 7, 2024
8 checks passed
@bwplotka
Copy link
Contributor

bwplotka commented Jan 8, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants