Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log analyzer failed with multiple containers in the pod #920

Merged
merged 6 commits into from
Feb 21, 2024
Merged

fix: log analyzer failed with multiple containers in the pod #920

merged 6 commits into from
Feb 21, 2024

Conversation

lili-wan
Copy link
Contributor

@lili-wan lili-wan commented Feb 6, 2024

Closes #884

📑 Description

Currently log analyzer will throw error when there are multiple containers inside one pod, this PR added the fix to scan individual container logs

Tested with my local pod that has multiple containers, efs-plugin is one of the container running inside pod efs-csi-node-us-west-2c-hn4jb

k8sgpt analyze --filter Log --namespace addon-efs-csi-ns
AI Provider: AI not used; --explain not set

0 addon-efs-csi-ns/efs-csi-node-us-west-2c-hn4jb/efs-plugin(DaemonSet/efs-csi-node-us-west-2c)
- Error: Mount attempt 1/3 failed due to timeout after 15 sec, wait 0 sec before next attempt.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

lwan3 added 2 commits February 6, 2024 12:05
Signed-off-by: lwan3 <lili_wan@intuit.com>
Signed-off-by: lwan3 <lili_wan@intuit.com>
@lili-wan lili-wan requested review from a team as code owners February 6, 2024 20:13
@lili-wan lili-wan changed the title Log analyzer failed with multiple containers in the pod #884 fix: Log analyzer failed with multiple containers in the pod Feb 6, 2024
@lili-wan lili-wan changed the title fix: Log analyzer failed with multiple containers in the pod fix: log analyzer failed with multiple containers in the pod Feb 6, 2024
Copy link
Contributor

@sbadla1 sbadla1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexsJones AlexsJones merged commit 98286a9 into k8sgpt-ai:main Feb 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Log analyzer failed with multiple containers in the pod
3 participants