Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lint errors #923

Merged
merged 1 commit into from
Feb 7, 2024
Merged

fix: lint errors #923

merged 1 commit into from
Feb 7, 2024

Conversation

amitamrutiya
Copy link
Contributor

Closes # #917

📑 Description

  • This pull request addresses all existing lint errors in the codebase. The primary goal was to improve code quality and maintainability by adhering to our established linting rules.
  • After making these changes, I ran the linter again to confirm that all lint errors have been fixed. The linter completed without any errors or warnings.
  • In addition to linting, I also ran our unit tests to ensure that these changes did not break any existing functionality. All tests passed successfully.

Current make lint command log screenshot
image

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Some of the lint errors have been fixed in pull request #916. To ensure the lint command works successfully, please merge both PRs.

Signed-off-by: amitamrutiya2210 <amitamrutiya2210@gmail.com>
@amitamrutiya amitamrutiya requested review from a team as code owners February 7, 2024 10:28
@AlexsJones
Copy link
Member

Thanks for this, looks to be useful :)

@AlexsJones AlexsJones merged commit 3415031 into k8sgpt-ai:main Feb 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants