Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: aws integration #967

Merged
merged 10 commits into from
Feb 26, 2024
Merged

feat: aws integration #967

merged 10 commits into from
Feb 26, 2024

Conversation

AlexsJones
Copy link
Member

Closes #

πŸ“‘ Description

βœ… Checks

  • [ x] My pull request adheres to the code style of this project
  • [x ] My code requires changes to the documentation
  • [x ] I have updated the documentation as required
  • [x ] All the tests have passed

β„Ή Additional Information

This initial integration will surface issues found in EKS beneath the current cluster

Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
@AlexsJones AlexsJones requested review from a team as code owners February 18, 2024 15:31
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Copy link
Contributor

@JuHyung-Son JuHyung-Son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome.

i have a question and a commnet.

what can we analyze only for eks? for cluster analyze, it is just same as normal k8sgpt since eks is cluster.
maybe we can use aws eks package itself not just k8s client.

and why not using k8sgpt global config kubeconfg? and fix .kube/config

pkg/integration/aws/aws.go Show resolved Hide resolved
pkg/integration/aws/eks.go Outdated Show resolved Hide resolved
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Copy link
Contributor

@JuHyung-Son JuHyung-Son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i give 2 comments

pkg/integration/aws/aws.go Show resolved Hide resolved
pkg/integration/aws/eks.go Outdated Show resolved Hide resolved
@AlexsJones AlexsJones merged commit a81377f into main Feb 26, 2024
10 checks passed
@AlexsJones AlexsJones deleted the feat/aws-integration branch February 26, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants