Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After applying invalid yaml mac addresses are not released #37

Open
kononovn opened this issue Jun 26, 2019 · 0 comments
Open

After applying invalid yaml mac addresses are not released #37

kononovn opened this issue Jun 26, 2019 · 0 comments

Comments

@kononovn
Copy link

Once you apply invalid yaml mac addresses are not released.
Scenario:
Step 1: Apply invalid yaml:
oc apply -f temp_a
The "" is invalid: spec.template.spec.networks: every network must be mapped to an interface

Step 2: Check logs
oc logs kubemacpool-mac-controller-manager-844cd8fbf8-rw6vk -n kubemacpool-system
{"level":"info","ts":1561535723.8990824,"logger":"PoolManager","msg":"mac from pool was allocated for virtual machine","allocatedMac":"02:aa:bf:00:00:01","virtualMachineName":"vma","virtualMachineNamespace":"myproject"}
{"level":"info","ts":1561535723.8990977,"logger":"PoolManager","msg":"mac from pool was allocated for virtual machine","allocatedMac":"02:aa:bf:00:00:02","virtualMachineName":"vma","virtualMachineNamespace":"myproject"}
{"level":"info","ts":1561535723.8991125,"logger":"PoolManager","msg":"mac from pool was allocated for virtual machine","allocatedMac":"02:aa:bf:00:00:03","virtualMachineName":"vma","virtualMachineNamespace":"myproject"}

Step 3: Reapply invalid yaml
oc apply -f temp_a

Step 4: Check logs:
oc logs kubemacpool-mac-controller-manager-844cd8fbf8-rw6vk -n kubemacpool-system
{"level":"info","ts":1561535798.2916842,"logger":"PoolManager","msg":"mac from pool was allocated for virtual machine","allocatedMac":"02:aa:bf:00:00:04","virtualMachineName":"vma","virtualMachineNamespace":"myproject"}
{"level":"info","ts":1561535798.2917054,"logger":"PoolManager","msg":"mac from pool was allocated for virtual machine","allocatedMac":"02:aa:bf:00:00:05","virtualMachineName":"vma","virtualMachineNamespace":"myproject"}
{"level":"info","ts":1561535798.2917206,"logger":"PoolManager","msg":"mac from pool was allocated for virtual machine","allocatedMac":"02:aa:bf:00:00:06","virtualMachineName":"vma","virtualMachineNamespace":"myproject"}
{"level":"info","ts":1561535798.2917743,"logger":"PoolManager","msg":"mac from pool was allocated for virtual machine","allocatedMac":"02:aa:bf:00:00:07","virtualMachineName":"vma","virtualMachineNamespace":"myproject"}

Bug: Once invalid yaml is applied mac addresses are not released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant