Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update section 4.1.2.1.4 mac #8

Open
adrianchiris opened this issue Jan 20, 2020 · 4 comments
Open

Update section 4.1.2.1.4 mac #8

adrianchiris opened this issue Jan 20, 2020 · 4 comments

Comments

@adrianchiris
Copy link

Quoting the Spec for network CRD:

4.1.2.1.4 "mac"
This optional key with value type string requires the plugin handling this network attachment to assign the given MAC address to the pod. This key’s value must contain a valid 6-byte Ethernet MAC address or a valid 20-byte IP-over-InfiniBand Hardware address (as described in RFC4391 section 9.1.1). If the value is invalid, the Network Attachment Selection Annotation shall be invalid and ignored by the implementation.

According to section 9.1.1 of IPoIB (IP over Infiniband) RFC an infiniband hardware address consists of 20 octets in the following format:

  • bytes 0-3 bytes are flags and queue pair number which user cannot control
  • bytes 4-19 GID which is composed as follows (can be found in IBTA Infiniband Specification):
  • 8 bytes subnet prefix - set by the infiniband subnet manager (initial value is 0xfe80000000000000)
  • 8 bytes GUID - the element which is user configurable

As the only element which is user configurable is the 8 byte GUID (Infiniband's version of MAC address) we should reword this section essentially removing the bits related to IP-Over-Infiniband.

It should be noted that it is still possible (and expected) for an IP over Infiniband CNI to return the full 20 octet hardware address under mac field which will be visible in network-status annotation, hence that part of the network CRD spec should not need changing.

I have created an issue in containernetworking/cni proposing to allow the configuration of the GUID part of the IPoIB hardware address. if and when it gets approved, support for it in multi-net-spec will be dealt with in this issue.

@adrianchiris
Copy link
Author

following the nwpg meeting we had last week,
would you prefer to open a google doc for it ?
(if yes, please specify what should be in the doc.)

Essentially i think we could simply modify the section as follows (simply remove the IP over Infiniband bits):

4.1.2.1.4 "mac"
This optional key with value type string requires the plugin handling this network attachment to assign the given MAC address to the pod. This key’s value must contain a valid 6-byte Ethernet MAC address. If the value is invalid, the Network Attachment Selection Annotation shall be invalid and ignored by the implementation.

Then if/once there is agreement on GUID configuration, we can update the doc again to reflect the latest changes.

@adrianchiris
Copy link
Author

@dcbw I have created a google doc with the proposed change, comments welcome.

@adrianchiris
Copy link
Author

@dcbw inputs are welcomed :)

@adrianchiris
Copy link
Author

This change was approved on NPWG meeting on 04.06.2020

Is there a periodic update of the spec ? as changes are not proposed directly to the source file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant