Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update e2e tests (replace j2cli with gomplate) #1265

Closed
wants to merge 1 commit into from
Closed

Update e2e tests (replace j2cli with gomplate) #1265

wants to merge 1 commit into from

Conversation

s1061123
Copy link
Member

@s1061123 s1061123 commented Apr 18, 2024 •
edited

Fix #1264

@coveralls
Copy link

Coverage Status

coverage: 62.778%. remained the same
when pulling 82302cc on s1061123:e2e-update
into 9c2771b on k8snetworkplumbingwg:master.

@killianmuldoon
Copy link

Am I right in seeing that this tool is only used on the e2e/templates folder and that it only sets the CNI_VERSION in ~4 places?

If so maybe envsubst is a good replacement - it's installed on most systems and it's exactly for this use case.

@s1061123
Copy link
Member Author

I got it. May need to file another one.

@s1061123 s1061123 closed this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[e2e] need to replace j2cli with something
3 participants
@s1061123 @coveralls @killianmuldoon