-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
thin_entrypoint should generate multus kubeconfig with manual option #1295
Comments
Any interest in trying a PR for it? I think this is reasonable to expect that functionality in 4.0. Please add testing to ensure that the kubeconfig generates and what not. Thank you! |
Thank you, will give it a try. :) |
Abdul -- not exactly sure what you're asking, mind submitting the change as you have it and we can look at the code? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Older version of multus e.g. 3.9.3 with older script of thin_entry.sh generates a multus.d directory and multus.kubeconfig file with a non-auto installation e.g. # "--multus-conf-file=/tmp/multus-conf/70-multus.conf"
The new version 4.0.2 with new thin_entrypoint doesn't generate multus.d and multus.kubeconfig if the installation type is non-auto. We still want multus to generate multus.kubeconfig even though if the configfile is used manually.
I believe adding below lines here would fix it.
caHash, saTokenHash, err = opt.createKubeConfig(nil, nil) if err != nil { fmt.Fprintf(os.Stderr, "failed to create multus kubeconfig: %v\n", err) return }
The text was updated successfully, but these errors were encountered: