Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thin plugin readiness check does not apply to config generation. #1306

Open
yifeng-cerebras opened this issue Jul 8, 2024 · 2 comments
Open

Comments

@yifeng-cerebras
Copy link

yifeng-cerebras commented Jul 8, 2024

What happend:
In case of node reboot, multus thin plugin failed to detect the master cni (cilium) even though we specified the readiness file for cilium.
We are using "auto" policy so it tries to find the first conf while cilium is not ready.

For thick plugin, it has the right implementation that readiness file missing will also block config generation.
Probably something similar can be done for thin plugin.

What you expected to happen:
Readiness file check also apply to config generation for thin plugin with auto policy.

How to reproduce it (as minimally and precisely as possible):
Delete main cni plugin and restart thin multus pod.

Anything else we need to know?:
We chose to use thin plugin as we discovered a more critical issue for thick.
When pods are initializing, force kill the daemon multus pod will cause pod stuck at init stage forever even after multus daemon pod recovered.
Probably worth another bug report. cc: @michaely-cb

Environment:

  • Multus version
    latest master
  • Kubernetes version (use kubectl version): 1.24.4
  • Primary CNI for Kubernetes cluster: cilium
  • OS (e.g. from /etc/os-release): rocky8.5
@dougbtv
Copy link
Member

dougbtv commented Jul 18, 2024

We chose to use thin plugin as we discovered a more critical issue for thick.

we'd like to know more about this, as well

@dougbtv
Copy link
Member

dougbtv commented Jul 18, 2024

If you can provide a procedure that we can use to both reproduce and test this, that would be very helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants