Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we want a stable tag? #367

Open
martinkennelly opened this issue Jul 26, 2021 · 4 comments
Open

Do we want a stable tag? #367

martinkennelly opened this issue Jul 26, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@martinkennelly
Copy link
Member

Now that #348 is merged..

What would you like to be added?

Add stable-${major version}-${arch} where arch is amd64, arm64 and ppc64le.

How?

We need to change deployments imagePullPolicy to make this work. I don't know if that's appealing..
We can extract major version number from docker meta to create the image tag.

        name: Docker meta
        id: docker_meta
        uses: crazy-max/ghaction-docker-meta@v1
        with:
          images: name/app
          tag-semver: |         
            {{major}}

What is the use case for this feature / enhancement?

Allow consumers to consume latest major version updates without updating their yamls. May aid automated testing infra.

Images we produce today

Tag Arch Description
latest x86 Latest commit
latest-amd64 x86 Latest commit
${GitHub SHA} x86 Git commit e.g "sha256:540af56cbd92b2dfdaea5bac3c44a6f46a277f0dbed000a0993d116fc377f332"
${GitHub tag} x86 GitHub Release tag e.g "v1.0"
latest-arm64 arm Latest commit
${GitHub tag}-arm64 arm GitHub Release tag e.g "v1.0-arm64"
latest-ppc64le power Latest commit
${GitHub tag}-ppc64le power GitHub Release tag e.g "v1.0-ppc64le"
@martinkennelly martinkennelly added enhancement New feature or request good first issue Good for newcomers and removed good first issue Good for newcomers labels Jul 26, 2021
@adrianchiris
Copy link
Contributor

This was discussed in K8s NPWG network & resource mgmt meeting on 08.10.2021. this enhancement proposal is approved.

documentation should be added as well, explaining the nature of the stable tag.
while it might be relevant for dev deployments and CI/testing, it will not be suitable for production.

while updating documentation it would also be great to document the images we are creating as depicted in this issue.

@zshi-redhat
Copy link
Collaborator

@martinkennelly @adrianchiris do we know anyone who is working on this proposal?

@martinkennelly
Copy link
Member Author

No.
@ipatrykx anyone on your side?

@ipatrykx
Copy link
Contributor

ipatrykx commented Oct 6, 2021

@martinkennelly Sorry, I was out of office for over 2 weeks.

After checking with @Eoghan1232 it seems that we don't have anyone working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants