Bump to 1.22.4 #729
Bump to 1.22.4 #729
Conversation
Signed-off-by: Balazs Nemeth <bnemeth@redhat.com>
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 9742331842Details
💛 - Coveralls |
| @@ -1,6 +1,6 @@ | |||
| module github.com/k8snetworkplumbingwg/sriov-network-operator | |||
|
|
|||
| go 1.22 | |||
| go 1.22.4 | |||
There was a problem hiding this comment.
@bn222 why do we need to require .4 explicitly ?
There was a problem hiding this comment.
gopls doesn't work with non-explicit z-stream. Also, our images downstream are 1.22.4. Making it explicit brings our env and upstream in alignment.
Side note: A difference between 1.22.1 and 1.22.4 causes code gen to behave differently. Making it explicit makes sure everyone is generating the same code.
There was a problem hiding this comment.
I don't like this approach. It will force us to. make more updates (1.22.5 is already releases). Could you please provide any real example how this will help?
There was a problem hiding this comment.
- gopls lsp servers doesn't work when you don't specify 1.22.4. There is an issue between 1.22.0 and 122.4.
- I'm not recommending always bumping versions to z-stream. If 1.22.5, we don't necessarily want it.
There was a problem hiding this comment.
Also, As far as I know. version specified in the go.mod file is the minum required version for this project to build.
https://go.dev/doc/modules/gomod-ref
So, there will be no need to bump this in the future in my opinion.
@bn222 do you have any reference (github issue, stackoverflow) to the problem with gopls?
There was a problem hiding this comment.
That's the closest I can find. On my system, after I've added .4, it started working.
Note also that operator-sdk generates a bit different code depending on 1.22 vs 1.22.4, so if someone is on 1.22.4, and they run make generate, they will generate different code than someone who is running on 1.22. IMO, it's better to be explicit on which version everyone should be on.
| @@ -1,6 +1,6 @@ | |||
| module github.com/k8snetworkplumbingwg/sriov-network-operator | |||
|
|
|||
| go 1.22 | |||
| go 1.22.4 | |||
There was a problem hiding this comment.
I don't like this approach. It will force us to. make more updates (1.22.5 is already releases). Could you please provide any real example how this will help?
|
@bn222 please correct me if I am wrong here but I think this only points to the min go version if I have an higher version I should be able and use it right? |
Correct. The generated binary will be compatible with 1.22.4 though. |
|
I will take this PR to the sriov-community meeting today. |
|
@e0ne this change just specified the minimal version of 1.22.x in go.mod so we should be ok. |
|
@e0ne ptal |
Bump to 1.22.4 Signed-off-by: Tobias Giese <tgiese@nvidia.com>
Bump to 1.22.4 Signed-off-by: Tobias Giese <tgiese@nvidia.com>
No description provided.