Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds more extensive options for svc type LoadBalancer for the zwave ui chart #35

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

wagnst
Copy link
Collaborator

@wagnst wagnst commented Jul 31, 2024

This pull request updates the service.yaml template to improve the handling of different service types in the Helm chart for zwave-js-ui. The changes ensure that the correct configuration is applied based on the specified service type.

Enhancements to service type handling:

  • Added conditional logic to set the type field to ClusterIP if the service type is either "ClusterIP" or empty.
  • Included additional configuration for LoadBalancer type services, such as setting loadBalancerIP and loadBalancerSourceRanges if specified in the values.
  • Added support for setting externalTrafficPolicy if it is specified in the values.LoadBalancer type allows additional values for loadBalancerIP (setting the desired LB IP) as well as externalTrafficPolicy.

LoadBalancer type allows additional values for loadBalancerIP (setting the desired LB IP) as well as externalTrafficPolicy.
@wagnst
Copy link
Collaborator Author

wagnst commented Jul 31, 2024

@varet80 would be great if you could have a look and merge if ok.
My values.yaml for this case would look like:

zwave-js-ui:

  service:
    type: LoadBalancer
    loadBalancerIP: 172.18.1.225
    externalTrafficPolicy: Local

@varet80 varet80 merged commit 92cf5ee into k8sonlab:main Jul 31, 2024
@wagnst wagnst deleted the patch-1 branch July 31, 2024 11:34
@varet80
Copy link
Collaborator

varet80 commented Jul 31, 2024

Thank you @wagnst.
I added you as contributor, you can create branches directly to repo! and also make the testing/merging easier

@wagnst
Copy link
Collaborator Author

wagnst commented Jul 31, 2024

Thank you @wagnst. I added you as contributor, you can create branches directly to repo! and also make the testing/merging easier

i've just re-released the latest tag so this can be used, hope that is fine!

@varet80
Copy link
Collaborator

varet80 commented Jul 31, 2024

All good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants