Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --sysctl #22

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Add support for --sysctl #22

merged 3 commits into from
Dec 1, 2023

Conversation

b-rad15
Copy link
Contributor

@b-rad15 b-rad15 commented Oct 18, 2023

Gonna be honest, don't entirely understand the codebase (or rust for that matter) but I tried to match this up with the existing params best I could (cap_add seemed to be the most similar so I based on that mostly) and it appears to work fine in accordance with the quadlet man page

@k9withabone
Copy link
Member

Thanks for your contribution! The Sysctl= quadlet option was added in podman 4.6.0 and the current minimum version for podlet is 4.5.0, so I won't merge this just yet. Support for podman 4.6.0 is next on my list though after the next patch release. I'm currently working on cleaning up the code a bit, please let me know what I can do to make it easier to understand!

@b-rad15
Copy link
Contributor Author

b-rad15 commented Oct 29, 2023

The biggest confusing things were just the lack of comments making it confusing which parts of the code did what, or what files corresponded to which subcommands. Also this might be my lack of Rust knowledge but understanding why some arguments had custom datatypes (iirc sysctl had one) where others did not and were just parsed directly to a vector of strings.

@k9withabone k9withabone merged commit 3c249ed into containers:main Dec 1, 2023
9 checks passed
@k9withabone k9withabone mentioned this pull request Dec 1, 2023
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants