From 40238b2a3541ada1cd5b05f81eaff960c6872428 Mon Sep 17 00:00:00 2001 From: Kenichi Kamiya Date: Sun, 2 Jun 2024 17:01:29 +0900 Subject: [PATCH] Add comment for adding validations for graceperiod Follow #821 --- dist/index.js | 2 ++ src/schema.ts | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/dist/index.js b/dist/index.js index e34c0668..06e9bf9c 100644 --- a/dist/index.js +++ b/dist/index.js @@ -31067,6 +31067,8 @@ var WaitFilterCondition = FilterCondition.extend( // - Intentionally avoided to use enum for now. Only GitHub knows whole eventNames and the adding plans // - Intentionally omitted in skip-list, let me know if you have the use-case eventName: z2.string().min(1).optional(), + // Do not raise validation errors for the reasonability of value range. + // Even in equal_intervals mode, we can't enforce the possibility of the whole running time startupGracePeriod: Durationable.default({ seconds: 10 }) } ).readonly(); diff --git a/src/schema.ts b/src/schema.ts index 0a08cca1..7e057611 100644 --- a/src/schema.ts +++ b/src/schema.ts @@ -65,9 +65,13 @@ const SkipFilterCondition = FilterCondition.readonly(); const WaitFilterCondition = FilterCondition.extend( { optional: z.boolean().optional().default(false).readonly(), + // - Intentionally avoided to use enum for now. Only GitHub knows whole eventNames and the adding plans // - Intentionally omitted in skip-list, let me know if you have the use-case eventName: z.string().min(1).optional(), + + // Do not raise validation errors for the reasonability of value range. + // Even in equal_intervals mode, we can't enforce the possibility of the whole running time startupGracePeriod: Durationable.default({ seconds: 10 }), }, ).readonly();