Show comments and login button for guests #46
Conversation
|
Storybook Hub is building storybooks for every commit in this PR. Latest Storybook: https://c5f07ef0-db95-48d0-87a7-247ddad39e06.sbook.io/
|
|
Here's how it looks: |
|
Added a disabled textarea and a login button which I think is more visible than the first version on wider screens. Here's a screenshot:
|
| @@ -10,7 +10,7 @@ | |||
| "testonly": "mocha --require .scripts/mocha_runner src/**/tests/**/*.js", | |||
| "test": "npm run lint && npm run testonly", | |||
| "test-watch": "npm run testonly -- --watch --watch-extensions js", | |||
| "storybook": "STORYBOOK_CLOUD_SERVER='http://localhost:3003/graphql' STORYBOOK_CLOUD_APPID='test-app' STORYBOOK_CLOUD_DATABASE='test-db' start-storybook -p 3006", | |||
| "storybook": "STORYBOOK_CLOUD_SERVER='http://localhost:3003/graphql' STORYBOOK_CLOUD_APPID='15a1beac-52b5-4ade-abeb-c2313f190c1f' STORYBOOK_CLOUD_DATABASE='7d9e7739-008b-43a2-9851-2dc8f41e391b' start-storybook -p 3006", | |||
There was a problem hiding this comment.
Do we need this?
If so, create a new NPM script for this.
| @@ -10,7 +10,7 @@ | |||
| "testonly": "mocha --require .scripts/mocha_runner src/**/tests/**/*.js", | |||
| "test": "npm run lint && npm run testonly", | |||
| "test-watch": "npm run testonly -- --watch --watch-extensions js", | |||
| "storybook": "STORYBOOK_CLOUD_SERVER='http://localhost:3003/graphql' STORYBOOK_CLOUD_APPID='test-app' STORYBOOK_CLOUD_DATABASE='test-db' start-storybook -p 3006", | |||
| "storybook": "STORYBOOK_CLOUD_SERVER='http://localhost:3003/graphql' STORYBOOK_CLOUD_APPID='15a1beac-52b5-4ade-abeb-c2313f190c1f' STORYBOOK_CLOUD_DATABASE='7d9e7739-008b-43a2-9851-2dc8f41e391b' start-storybook -p 3006", | |||
There was a problem hiding this comment.
Do we need these ids. Does this work everywhere?
Anyway, I think it's pretty great if we create a new NPM script.
There was a problem hiding this comment.
My bad. I used them when testing locally. I'll get rid of them. It'll work everywhere as long as we have an app for this repo on Storybook Hub. But we must get rid of these env vars for that
There was a problem hiding this comment.
We add these because, it's pretty helpful when we test locally. Just run the npm script start working on the comments addon.
But if we have a better way to do this, then that's fine.
There was a problem hiding this comment.
Take this PR, when you remove these ids.
Also try to document on the contribution guide on how to test with public apps.
This will only work for public apps. It still shows "No Comments Yet!" for for Private apps which is not true. Must update the UI to mention when the app is private.